Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift from existing utilities to broader starknet.js usage #411

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

penovicp
Copy link
Contributor

Usage related changes

  • TODO
  • ...

Development related changes

  • TODO
  • ...

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC
Copy link
Collaborator

Aside from this PR now hving conflicts with master, it is also in conflict with #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants