Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

feat: asset-swapper market depth #2641

Merged
merged 6 commits into from
Jul 27, 2020
Merged

feat: asset-swapper market depth #2641

merged 6 commits into from
Jul 27, 2020

Conversation

dekz
Copy link
Member

@dekz dekz commented Jul 21, 2020

Description

Adds getBidAskLiquidityForMakerTakerAssetPairAsync which returns the raw liquidity from asset-swapper

  • getMarket{Buy|Sell}LiquidityAsync does all the liquidity finding things and returns it pretty raw as a MarketSideLiquidity interface
  • Attached PLP address to the PLP fillData so we don't have to pass it all the way down as a parameter
  • Attached MultiBridge address to the MultiBridge fillData so we don't have to pass it all the way down as a parameter

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@dekz dekz force-pushed the feat/depth-chart branch from be63c32 to 42096ba Compare July 26, 2020 01:36
@dekz dekz marked this pull request as ready for review July 26, 2020 23:56
@dekz dekz force-pushed the feat/depth-chart branch from fba6c7e to 8961d49 Compare July 27, 2020 00:32
@dekz dekz force-pushed the feat/depth-chart branch from 8961d49 to 3e471fd Compare July 27, 2020 01:16
@dekz dekz merged commit 5afe261 into development Jul 27, 2020
@dekz dekz deleted the feat/depth-chart branch July 27, 2020 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants