This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: support renamed parameters in RFQT maker endpoint #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deploy staging |
steveklebanoff
approved these changes
Jun 17, 2020
|
deploy staging |
|
Confirmed to be working properly on staging:
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2020
# [1.9.0](v1.8.0...v1.9.0) (2020-06-22) ### Bug Fixes * asset swapper monorepo f14b6f2ba ([#257](#257)) ([a03630a](a03630a)) * Disable quote validation temporarily ([#259](#259)) ([6064f3e](6064f3e)) * filter tokens in prices which do not exist on the network ([#265](#265)) ([864ea92](864ea92)) * Fix parameters sent off to RFQT providers to be unescaped ([#264](#264)) ([939cae1](939cae1)) * validation gas limit ([#260](#260)) ([f50425c](f50425c)), closes [#259](#259) * WETH wrap gas estimate ([#256](#256)) ([f07b4a8](f07b4a8)) ### Features * add signer liveness status gauge ([#255](#255)) ([11446e7](11446e7)) * support renamed parameters in RFQT maker endpoint ([#258](#258)) ([d83bbb1](d83bbb1))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a new asset-swapper, which has support for the maker endpoint's renamed taker request parameters.
developmentcommit rather than a PR branch commit, once asset-swapper: Use @0x/quote-server, not local typedefs; and adapt to renamed taker request parameters 0x-monorepo#2582 has been merged.