Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: proxy cleanup #997

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore: proxy cleanup #997

merged 1 commit into from
Dec 2, 2024

Conversation

SantiagoPittella
Copy link
Collaborator

Closes #986

  • Updates pingora crates to 0.4
  • Uses Uuid v4 instead of u128.
  • Adds polling time to the configuration file.

bobbinth
bobbinth approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-proxy-cleanup branch from 4f77579 to 66dcff6 Compare December 2, 2024 16:08
tomyrd
tomyrd approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@tomyrd tomyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-proxy-cleanup branch from 66dcff6 to f7e861d Compare December 2, 2024 21:07
@SantiagoPittella SantiagoPittella merged commit 6727213 into next Dec 2, 2024
9 checks passed
@SantiagoPittella SantiagoPittella deleted the santiagopittella-proxy-cleanup branch December 2, 2024 21:59
@bobbinth bobbinth mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomyrd tomyrd tomyrd approved these changes

@bobbinth bobbinth bobbinth approved these changes

@igamigo igamigo Awaiting requested review from igamigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SantiagoPittella @tomyrd @bobbinth