Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make AccountIdError public #1067

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: make AccountIdError public #1067

merged 3 commits into from
Jan 15, 2025

Conversation

SantiagoPittella
Copy link
Collaborator

No description provided.

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-expose-account-id-error branch from 247b258 to a3f0d18 Compare January 15, 2025 15:29
@SantiagoPittella SantiagoPittella marked this pull request as ready for review January 15, 2025 15:30
PhilippGackstatter
PhilippGackstatter approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the oversight of not making this public.

@igamigo igamigo merged commit d09a78e into next Jan 15, 2025
11 checks passed
@igamigo igamigo deleted the santiagopittella-expose-account-id-error branch January 15, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGackstatter PhilippGackstatter PhilippGackstatter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SantiagoPittella @PhilippGackstatter @igamigo