feat: account ID refactor additional methods #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
reviewed
Dec 26, 2024
objects/src/block/header.rs
Outdated
| @@ -186,6 +186,11 @@ impl BlockHeader { | |||
| self.timestamp | |||
| } | |||
|
|
|||
| /// Returns the block number of the epoch block to which this block belongs. | |||
| pub fn get_epoch_block_num(&self) -> u32 { | |||
There was a problem hiding this comment.
I think I'd just name this epoch_block_num() since it's a very basic computation over the block num (and also it would be analogous to BlockHeader::block_epoch()).
EDIT: Just saw that the original comment suggested the current naming. If we follow that maybe block_epoch could also have get_ as a prefix? It's a minor detail so no worries either way.
There was a problem hiding this comment.
I think the first suggestion matches better with the rest of the methods in BlockHeader
igamigo
approved these changes
Dec 26, 2024
|
@tomyrd - could you also add a changelog entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two small quality of life methods to
AccountIdPrefixandBlockHeader. Both stemming from comments in this review.