Audit fixes

0xPolygonHermez · Jan 15, 2025 · b96e2cc · b96e2cc
1 parent 4741dfe
commit b96e2cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/main/p256verify/dblScalarMulSecp256r1.zkasm b/main/p256verify/dblScalarMulSecp256r1.zkasm
@@ -364,7 +364,7 @@ dblScalarMulSecp256r1_save_k10_k21:
 ;     if (latch == 0):
 ;         print("\t$ => C\t\t\t:MLOAD(dblScalarMulSecp256r1_acum_k1), JMP(dblScalarMulSecp256r1_save_k10_k20)  ; RR = {}".format(i))
 ;     else:
-;         print("\tRR - 1 => RR\t:JMPN(dblScalarMulSecp256r1_end_loop,dblScalarMulSecp256r1_double_noRR)\t\t\t; RR = {}".format(i))
+;         print("\tRR - 1 => RR\t:JMPN(dblScalarMulSecp256r1_end_loop,dblScalarMulSecp256r1_double_noRR)\t\t\t; RR = {}".format(i)) # RR - 1 >= 0, but we leave the JMPN for understanding
 ; ----------------------------------------
 dblScalarMulSecp256r1_scalar_table_k10_k20:
 	$ => C			:MLOAD(dblScalarMulSecp256r1_acum_k1), JMP(dblScalarMulSecp256r1_save_k10_k20)  ; RR = 0

diff --git a/main/p256verify/p256verify.zkasm b/main/p256verify/p256verify.zkasm
@@ -101,7 +101,7 @@ p256verify_correctness_checks:
         $ => B          :MLOAD(p256verify_y)
         $               :LT, JMPC(p256verify_error_y_is_too_big)
 
-        ; 5] Check whether PK = (x,y) is the point at infinity 𝒪
+        ; 5] Early return if PK = (x,y) is the point at infinity 𝒪 := (0,0). This condition would also be caught by the following elliptic curve equation check.
         0n => B
         $ => A          :MLOAD(p256verify_x)
         $               :EQ, JMPNC(p256verify_pk_not_point_at_infinity)