Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethtxmanager improvements #2664

Merged
merged 70 commits into from
Oct 30, 2023

Conversation

tclemos
Copy link
Contributor

@tclemos tclemos commented Oct 14, 2023

Closes #2329.

What does this PR do?

  • improve EthTxManager performance allowing multiple TXs to be monitored in parallel
  • Move gas offset from hardcode to callers configuration following the hardcoded values as default values.

Default values

[SequenceSender]
GasOffset = 80000

[Aggregator]
GasOffset = 0

ToniRamirezM and others added 30 commits June 30, 2023 16:40
* Hotfix v0.1.4 to main (#2250)

* fix concurrent web socket writes

* fix eth_syncing

* fix custom trace internal tx call error handling and update prover

* add test to custom tracer depth issue; fix internal call error and gas used

* fix custom tracer for internal tx with error and no more steps after it

* remove debug code

* Make max grpc message size configurable  (#2179)

* make max grpc message size configurable

* fix state tests

* fix tests

* fix tests

* get SequencerNodeURI from SC if empty and not IsTrustedSequencer

* Optimize trace (#2183)

* optimize trace

* fix memory reading

* update docker image

* update prover image

* fix converter

* fix memory

* fix step memory

* fix structlogs

* fix structlogs

* fix structlogs

* fix structlogs

* fix structlogs

* fix structlogs

* fix structlogs

* fix structlogs

* update prover image

* fix struclogs

* fix memory size

* fix memory size

* fix memory size

* refactor memory resize

* refactor memory resize

* move log for the best fitting tx (#2192)

* fix load zkCounters from pool

* remove unnecessary log.info

* add custom tracer support to CREATES opcode without depth increase (#2213)

* logs

* fix getting stateroot from previous batch (GetWIPBatch)

* logs

* Fix GetWipBatch when previous last batch is a forced batch

* fix forcedBatch trusted state

* Revert "fix getting stateroot from previous batch (GetWIPBatch)"

This reverts commit 860f0e7.

* force GHA

* add pool limits (#2189)

* Hotfix/batch l2 data (#2223)

* Fix BatchL2Data

* Force GHA

* remove failed txs from the pool limit check (#2233)

* debug trace by batch number via external rpc requests (#2235)

* fix trace batch remote requests in parallel limitation (#2244)

* Added RPC.TraceBatchUseHTTPS config parameter

* fix executor version

---------

Co-authored-by: tclemos <[email protected]>
Co-authored-by: tclemos <[email protected]>
Co-authored-by: Toni Ramírez <[email protected]>
Co-authored-by: agnusmor <[email protected]>
Co-authored-by: agnusmor <[email protected]>
Co-authored-by: Thiago Coimbra Lemos <[email protected]>

* fix test

* fix test

---------

Co-authored-by: tclemos <[email protected]>
Co-authored-by: tclemos <[email protected]>
Co-authored-by: Toni Ramírez <[email protected]>
Co-authored-by: agnusmor <[email protected]>
Co-authored-by: agnusmor <[email protected]>
Co-authored-by: Thiago Coimbra Lemos <[email protected]>
* effective GasPrice refactor

* bugs fixes and finalizer tests fixes

* fix typo

* fix calculate effective gasprice percentage

* fix test gas price
* effective gas price returned by the rpc in the receipt

* linter
* bugfix: fixing l2blocks timestamp for the fist batch

Signed-off-by: Nikolay Nedkov <[email protected]>

* fix finalizer unit test

---------

Signed-off-by: Nikolay Nedkov <[email protected]>
…ssword from etherman.Config that are not in use
* fix fea2scalar and gas used

* suggestion

* fix fea2scalar

* suggestion
* fix pending tx when duplicate nonce

* set pool.transaction.failed_reason to NULL when updating an existing tx

* add more log details when adding tx to AddrQueue

* fix query to add tx to the pool. Fix lint errors

* change failed_reason for tx discarded due duplicate nonce
* Return a tx from the pool only if it is

* fix TestGetTransactionByHash

---------

Co-authored-by: agnusmor <[email protected]>
…entation-for-node-config-file-2

Feature/#2200 generate json-schema + docs for node config file and network_custom
…ork-id-to-skip-effectivePercentage

improve: adding check to skip appending effectivePercentage if current forkId is under 5.
…on-batch-num

feat: adding functionality to stop sequencer on specific batch num from config param.
… log conversion (#2280)

* fix and check order

* linter
…eal-IP

patch: adding print for X-Real-IP in JSON-RPC
@tclemos tclemos added this to the v0.5.0 milestone Oct 14, 2023
@tclemos tclemos self-assigned this Oct 14, 2023
@cla-bot cla-bot bot added the cla-signed label Oct 14, 2023
@tclemos tclemos modified the milestones: v0.6.0, v0.4.0 Oct 25, 2023
@tclemos tclemos marked this pull request as ready for review October 25, 2023 13:03
@tclemos tclemos added the config label Oct 25, 2023
@joanestebanr joanestebanr merged commit 49a734a into develop Oct 30, 2023
@joanestebanr joanestebanr deleted the feature/eth-tx-manager-gas-price-improvements branch October 30, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eth Tx Manager and Out of Gas reverted tx
6 participants