Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment gas price with at least 10% #2378

Conversation

jbearer
Copy link
Contributor

@jbearer jbearer commented Aug 5, 2023

Many RPC and miner implementations automatically discard replacement transactions where the gas price is not increased by at least 10%. If this happens, the ethtxmanager can end up adding transactions to the history of a monitored transaction that have no effect, until the history size limit is quickly reached and the monitored transaction is considered failed.

@cla-bot
Copy link

cla-bot bot commented Aug 5, 2023

We require contributors/corporates @sveitser to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@cla-bot
Copy link

cla-bot bot commented Aug 7, 2023

We require contributors/corporates @sveitser to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@cla-bot
Copy link

cla-bot bot commented Aug 7, 2023

We require contributors/corporates @sveitser to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@sveitser
Copy link

sveitser commented Aug 8, 2023

Happy to sign the CLA. Do I need to make a PR to https://github.com/0xPolygonHermez/clabot-config/ ?

@tclemos
Copy link
Contributor

tclemos commented Aug 8, 2023

@jbearer, thanks for your suggestion!

We had a discussion internally and we will be applying some changes to the EthTxmanager to handle this and other situations soon.
We have already merged a PR to help with this specific situation, as you can see here:
#2360

@tclemos tclemos closed this Aug 8, 2023
@jbearer
Copy link
Contributor Author

jbearer commented Aug 8, 2023

Ah don't know how I missed that. Glad to hear it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants