improve: storing 'batch_resources' and 'closing_reason' in 'state.batch' on closing a batch. #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch' on closing a batch. Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
feature/save-batch-constraints-in-db
branch
from
a0ed81a to
f72e0d7
Compare
ToniRamirezM
approved these changes
Apr 14, 2023
sequencer/finalizer.go
Outdated
| } else if zkCounters.CumulativeGasUsed <= f.getConstraintThresholdUint64(f.batchConstraints.MaxCumulativeGasUsed) { | ||
| result = true | ||
| } | ||
| f.batch.closingReason = state.BatchAlmostFullClosingReason |
There was a problem hiding this comment.
I am not sure. Should we check here if result == true ?
|
Added the new closing reason: timeout resolution |
Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
feature/save-batch-constraints-in-db
branch
from
05fdf10 to
a2b52eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1810
What does this PR do?
Storing
batch_resourcesandclosing_reasoninstate.batchon closing a batch.Reviewers
Main reviewers: