phase2(flag): create type 1 rollup flag #1803
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo/cli/flags_zkevm.go
Outdated
| @@ -177,6 +177,9 @@ func ApplyFlagsForZkConfig(ctx *cli.Context, cfg *ethconfig.Config) { | |||
| } | |||
| } | |||
|
|
|||
| // set type 1 enabled as a global var for easier access | |||
| ethconfig.Type1Enabled = ctx.Bool(utils.EnableType1Rollups.Name) | |||
There was a problem hiding this comment.
I doubt about keeping it global rather than a part of the config. This introduces inconsistency with other flags and makes it harder to maintain as a result. Now we ll need to keep track of the zk config and this flag separately, if moved, inherited, or initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.