fix: return error instead of infinitely hanging monitor #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
polycli monitorwill infinitely hang in cases where it can connect to a valid RPC endpoint, but does not receive valid responses. This PR allows monitor to receive those errors and return them and exit after a5second waiting time for the UI to render.Testing
Before
The RPC is valid, so monitor will continue attempting to render the UI, but the responses will be invalid. So it will never load and be stuck in this state.
After
polycli monitorshould now return the error message and exit. This image shows a test with a custom error.