Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context for dockerfile build #9

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

sshrihar
Copy link
Contributor

@sshrihar sshrihar commented Mar 6, 2024

Pull Request Template

Description

For reusable github workflow the dockerfile context needs to be changed to the containing directory. This update fixes the issue when dockerfile may be contained in a sub-app and the context is required to be changed.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

Before you submit your pull request, please make sure you have completed the following:

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run lint to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if appropriate):

Include any screenshots that will help explain your changes.

Additional context

Add any other context about the pull request here.

@sshrihar sshrihar requested review from a team as code owners March 6, 2024 13:42
@sshrihar sshrihar merged commit 570a68e into main Mar 6, 2024
1 check failed
@sshrihar sshrihar deleted the DEVOPS-2622-ethereum-producer-deployment branch March 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants