Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update coralogix config for taskdef template #16

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

sreevalsanmr
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before you submit your pull request, please make sure you have completed the following:

  • My code follows the style guidelines of this project and I have run lint to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Additional context

Add any other context about the pull request here.

Copy link

sonarcloud bot commented Sep 24, 2024

"secrets": [
{
"name": "SSM_CONFIG",
"valueFrom": "arn:aws:ssm:$region:$account_number:parameter/CORALOGIX/CX_OTEL/config.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For apps which are using this will stop working since they may not have access to arn:aws:ssm:eu-west-1:<account_number>:parameter/CORALOGIX/*

@sreevalsanmr sreevalsanmr merged commit 98a5e1c into main Sep 25, 2024
4 checks passed
@sreevalsanmr sreevalsanmr deleted the DEVOPS-3243 branch October 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants