Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry pick pr 217 and 209 from release/v0.5.0 #224

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Dec 4, 2024

Description

Cherry pick PR #217 and PR #209 from release/v0.5.0

This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation)
There are a special situation that is going to send a certificate bigger than maximium:
- [ initial_block, end_block ] -> size exceed
- [ initial_block, (end_block -1) ] -> no bridges, so we have to send previous one even that exceed the maximum size

MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb
```
[AggSender]
MaxCertSize = 8388608
```
@joanestebanr joanestebanr changed the title Feature/cherry pick pr 217 feat: cherry pick pr 217 from release/v0.5.0 Dec 4, 2024
@joanestebanr joanestebanr marked this pull request as ready for review December 4, 2024 09:39
@joanestebanr joanestebanr self-assigned this Dec 4, 2024
Copy link

sonarcloud bot commented Dec 4, 2024

@joanestebanr joanestebanr changed the title feat: cherry pick pr 217 from release/v0.5.0 feat: cherry pick pr 217 and 209 from release/v0.5.0 Dec 4, 2024
@joanestebanr joanestebanr merged commit f647eda into develop Dec 4, 2024
13 checks passed
@joanestebanr joanestebanr deleted the feature/cherry-pick-pr-217 branch December 4, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants