Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-4769 feat(portal,graphql): user profile metadata left panel #940

Merged
merged 9 commits into from
Nov 21, 2024
Merged

ENG-4769 feat(portal,graphql): user profile metadata left panel #940

merged 9 commits into from
Nov 21, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Updates queries and fragments to support what we need for the user metadata. Runs codegen
  • Uses the useGetVaultDetails hook and GraphQL hooks for all user data (excluding Points)
  • This includes several TODO comments flagging our need to fix/update the type safety once we lock it all in
  • This breaks the View All Tags modal but there are a lot of other pieces we need to fix to get this to work and we'll need to revisit it

Screen Captures

graphql-user-profile-metadata

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@jonathanprozzi
Adds a GetConnectionsCount aggregate query for use in the profile met…
5e6d9af 
…adata
@jonathanprozzi
Adds core queries for the account metadata (left panel) in the user p…
16dac63 
…rofile route
@jonathanprozzi
Replaces all metadata calls with GraphQL and scaffolds most of what i…
45b0e90 
…s needed for the tags/tag modal
@jonathanprozzi
Updates the data flow to use GraphQL, tweaks components, and adds tem…
e2319b2 
…porary fixes until we fully round out our new types
@jonathanprozzi
Updates the AtomVaultDetails fragment to include more info needed for…
18257e5 
… profile use case, runs codegen
@jonathanprozzi
Adjusts the accounts query fragment placement and runs codegen
ba50ad9
@jonathanprozzi
Updates queries and runs codegen, updates values passed into Position…
9781103 
…Card to use new GraphQL values (we will need to adjust the types here once locked in)
@jonathanprozzi
Updates the types and components to work with new values, but going t…
1b2ab5d 
…o take another pass at this to see if more can be done right now. Removes followClaim and tagClaims
@jonathanprozzi
Replaces the types and renames until we can do a full sweep of them. …
07a77c7 
…Adds eslint ignores and TODOs
@linear Linear
Copy link

linear bot commented Nov 21, 2024

ENG-4769 User Profile: Metadata (left panel)

@github-actions github-actions bot added the feat Feature label Nov 21, 2024
@jonathanprozzi jonathanprozzi merged commit aee7fc3 into feature/graphql-migration Nov 21, 2024
2 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-4769-user-profile-metadata-left-panel branch November 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitalsine85 Vitalsine85 Vitalsine85 approved these changes

Assignees
No one assigned
Labels
feat Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanprozzi @Vitalsine85