ENG-0000 fix(portal,1ui): Fix Privy auth issues #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +32,10 @@ export default function PrivyLoginButton({ | |||
| setLoading(true) | |||
| login() | |||
| } | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
So this would force the logout to ensure it's cleared fully before logging in?
jonathanprozzi
requested changes
Nov 21, 2024
| useEffect(() => { | ||
| if (accessToken) { | ||
| // instead of revalidating, redirect to same route and replace true | ||
| console.log('Redirecting to', `${refreshPath}?redirectTo=${redirectTo}`) |
There was a problem hiding this comment.
Suggested change
| console.log('Redirecting to', `${refreshPath}?redirectTo=${redirectTo}`) | |
| logger('Redirecting to', `${refreshPath}?redirectTo=${redirectTo}`) |
| } | ||
|
|
||
| // Then get the full user object directly using the verified user ID | ||
| const user = await privyClient.getUserById(verifiedClaims.userId) |
Co-authored-by: Jonathan Prozzi <[email protected]> Signed-off-by: jojikun <[email protected]>
Co-authored-by: Jonathan Prozzi <[email protected]> Signed-off-by: jojikun <[email protected]>
Co-authored-by: Jonathan Prozzi <[email protected]> Signed-off-by: jojikun <[email protected]>
Co-authored-by: Jonathan Prozzi <[email protected]> Signed-off-by: jojikun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Overview of the changes in the PR.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration