Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-0000 fix(portal): changes httpOnly logic to false and wraps verifyPrivyAccessToken #933

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Updates the cookie check logic to httpOnly to false
  • Wraps the verifyPrivyAccessToken in a try/catch block

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@github-actions github-actions bot added the fix Fix label Nov 19, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-0000 fix(portal): changes httpOnly logic to false ENG-0000 fix(portal): changes httpOnly logic to false and wraps verifyPrivyAccessToken Nov 19, 2024
@0xjojikun 0xjojikun enabled auto-merge (squash) November 19, 2024 23:41
@0xjojikun 0xjojikun merged commit 0972d7d into main Nov 19, 2024
4 checks passed
@0xjojikun 0xjojikun deleted the eng-0000-fix-privy-cookie-logic branch November 19, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants