Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-4797 fix(portal): prevent vault details fetch before stake modal is opened #930

Merged
merged 1 commit into from
Nov 19, 2024
Merged

ENG-4797 fix(portal): prevent vault details fetch before stake modal is opened #930

merged 1 commit into from
Nov 19, 2024

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Overview of the changes in the PR.

Screen Captures

  • Fixes an issue where StakeModal was trying to fetch vault details before it was opened which was causing a 500 because vault_id was undefined.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@linear Linear
Copy link

linear bot commented Nov 19, 2024

ENG-4797 Prevent StakeModal from fetching vault details before it is opened

@github-actions github-actions bot added the fix Fix label Nov 19, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) November 19, 2024 20:56
@Vitalsine85 Vitalsine85 merged commit 07d25e7 into main Nov 19, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4797-prevent-stakemodal-from-fetching-vault-details-before-it-is branch November 19, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanprozzi jonathanprozzi jonathanprozzi approved these changes

@0xjojikun 0xjojikun Awaiting requested review from 0xjojikun

Assignees
No one assigned
Labels
fix Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vitalsine85 @jonathanprozzi