ENG-4713 fix(portal,1ui): remove staking from identity rows on list detail #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanprozzi
approved these changes
Nov 15, 2024
Vitalsine85
force-pushed
the
vital/eng-4713-remove-staking-from-rows-on-list-detail
branch
from
f6c8b1c
to
c8a3fab
Compare
Vitalsine85
deleted the
vital/eng-4713-remove-staking-from-rows-on-list-detail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
** This was branched off of
vital/eng-4712-responsiveness-fixes. Make sure that gets merged in first, and rebase this off main before merging**Removes the staking buttons and context menu from IdentityRow on List Detail route. Staking was removed because it doesn't make sense in this context, you'd be staking on the subject identity of the has tag claim, and we already have the save list functionality baked into this. Removed the context button because it lives inside of IdentityRow and clashes with the save list button. Should revisit when we get to the list and detail page rework and create a specific row component for list details.
Screen Captures
Declaration