Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4708 fix(portal,1ui): fix skeletons for listcards and featured lists carousel #910

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Updates Skeleton size to match FeaturedListsCarousel
  • Resizes icon Avatar on ListCards

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 13, 2024

@github-actions github-actions bot added the fix Fix label Nov 13, 2024
@Vitalsine85 Vitalsine85 merged commit 377c120 into main Nov 14, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4708-fix-skeletons-for-listcards-and-featured-lists-carousel branch November 14, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants