Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4704 fix(portal,1ui): refine gradients in claim and identity row #909

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Nov 13, 2024

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Improved the gradient and color on ClaimRow and IdentityRow for better visibility
  • Improved visibility of StakeButton on IdentityRow when a user has a position
  • Improved the gradient on the TabList in StakeForm

Screen Captures

image
image
image

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 13, 2024

@github-actions github-actions bot added the fix Fix label Nov 13, 2024
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The gradients look really smooth and balanced!

@@ -37,7 +37,7 @@ export interface IdentityRowProps extends React.HTMLAttributes<HTMLDivElement> {
numPositions: number
tags?: TagWithValueProps[]
userPosition?: string
onStakeClick: () => void
onStakeClick?: () => void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah -- this is what you mentioned before as a temporary workaround until we can ensure the user's positions are available in the Activity feeds.

@Vitalsine85 Vitalsine85 merged commit 947e772 into main Nov 14, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4704-claimrow-and-identityrow-refinements branch November 14, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants