ENG-4447 fix(portal): fix vault_id is null after identity creation #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanprozzi
approved these changes
Nov 12, 2024
| topics: receipt?.logs[0].topics, | ||
| }) | ||
|
|
||
| console.log('decodedLog', decodedLog) |
There was a problem hiding this comment.
Let's remove this or change to use logger
There was a problem hiding this comment.
Good callout, completely forgot I added that
Vitalsine85
deleted the
vital/eng-4447-view-identity-button-in-create-identity-form-is-passing
branch
0xjojikun
pushed a commit
that referenced
this pull request
Nov 22, 2024
) ## Affected Packages Apps - [ ] data populator - [x] portal - [ ] template Packages - [ ] 1ui - [ ] api - [ ] graphql - [ ] protocol - [ ] sdk Tools - [ ] tools ## Overview Fixed an issue where vault_id was being passed as null into the completion screen when creating an identity which was causing the 'View Identity' button to navigate to a bad route. ## Screen Captures If applicable, add screenshots or screen captures of your changes. ## Declaration - [x] I hereby declare that I have abided by the rules and regulations as outlined in the [CONTRIBUTING.md](https://github.com/0xIntuition/intuition-ts/blob/main/CONTRIBUTING.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Fixed an issue where vault_id was being passed as null into the completion screen when creating an identity which was causing the 'View Identity' button to navigate to a bad route.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration