Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4630 feat(1ui): smart component consumer pattern example -- 1ui + graphql data #883

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Adds in scaffolding to be able to use our graphql package within 1ui to make our first iteration of smart components -- at this stage this is only at the .stories level where a Live Data story has been added
  • Adds in React Query and graphql-request as dev dependencies to be able to support this
  • We also need to bring our formatting utils over from Portal to support this -- I started to do this but had a conflict with our formatNumber in 1ui so I held off. We should likely pull these into a utils package and import from there.
  • We also likely want to move this type of functionality into its own package, but I wanted to add this scaffolding incase it's useful for us as we migrate to GraphQL

Screen Captures

image

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

… in 1ui -- we should standardize and move to a utils package within monorepo
… in 1ui -- we should standardize and move to a utils package within monorepo
Copy link

linear bot commented Nov 4, 2024

ENG-4630 Smart Component consumer pattern example: 1ui + graphql data

TLDR:

Functional Requirement(s):

Task Breakdown - should translate to sub-issues if applicable:

  • [ ]

@jonathanprozzi jonathanprozzi changed the title ENG-4630: smart Component consumer pattern example: 1ui + graphql data ENG-4630: smart component consumer pattern example: 1ui + graphql data Nov 4, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-4630: smart component consumer pattern example: 1ui + graphql data ENG-4630 feat(1ui): smart component consumer pattern example -- 1ui + graphql data Nov 4, 2024
@github-actions github-actions bot added the feat Feature label Nov 5, 2024
@jonathanprozzi jonathanprozzi merged commit b7919f7 into main Nov 6, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-4630-smart-component-example branch November 6, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants