Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-0000 fix(data-populator): adds in the last step to finalize status #872

Merged
merged 2 commits into from
Oct 22, 2024
Merged

ENG-0000 fix(data-populator): adds in the last step to finalize status #872

merged 2 commits into from
Oct 22, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal
  • data-populator

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Now updates the status to 'fulfilled' upon successfully completing the flow -- missed this part in the original flow!
  • Tested the flow again and everything is working after this addition

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@github-actions github-actions bot added the fix Fix label Oct 22, 2024
@jonathanprozzi jonathanprozzi enabled auto-merge (squash) October 22, 2024 15:29
@jonathanprozzi jonathanprozzi merged commit 8db6dc5 into main Oct 22, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-0000-fix-add-db-fulfillment branch October 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjojikun 0xjojikun 0xjojikun approved these changes

Assignees
No one assigned
Labels
fix Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanprozzi @0xjojikun