Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4264 feat(data-populator): Port ethers to viem #867

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

auroter
Copy link
Member

@auroter auroter commented Oct 18, 2024

Affected Packages

Apps

  • portal
  • Data Populator

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Ported ethers to viem

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Oct 18, 2024

ENG-4264 [Data Populator] Port ethers code to viem

TLDR:

There are a few lines of code which use ethers that need to be ported over to viem in order to maintain cohesion in our codebase:

  1. Signer / Provider Method

  2. Populate Transaction

  3. Estimate Gas

@0xjojikun 0xjojikun changed the title Sean/eng 4264 port ethers to viem ENG-4264 feat(data-populator):Port ethers to viem Oct 18, 2024
@0xjojikun 0xjojikun changed the title ENG-4264 feat(data-populator):Port ethers to viem ENG-4264 feat(data-populator): Port ethers to viem Oct 18, 2024
Copy link
Member

@0xjojikun 0xjojikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 minor comment, other than that lgtm

@github-actions github-actions bot added the feat Feature label Oct 18, 2024
@auroter auroter merged commit 5a7d430 into main Oct 18, 2024
3 checks passed
@auroter auroter deleted the sean/ENG-4264-port-ethers-to-viem branch October 18, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants