Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-4443 feat(repo): scaffold data populator app #860

Merged
merged 42 commits into from
Oct 17, 2024
Merged

ENG-4443 feat(repo): scaffold data populator app #860

merged 42 commits into from
Oct 17, 2024

Conversation

jonathanprozzi
Copy link
Member

@jonathanprozzi jonathanprozzi commented Oct 11, 2024 •
edited
Loading

Affected Packages

Apps

  • portal
  • template
  • data populator

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • This is branched off the template PR branch ENG-3931 feat(template): create privy template in monorepo -- phase one #859 -- if we merge in that first, the diff on this PR will be reduced since it's branched off this and using the template
  • Refactors to use 1ui and other monorepo utils
  • Adds smart wallet support
  • Refactors to remove artifacts from when this ran as a CLI
  • Refactors to fix lint and type issues to satisfy monorepo's checks

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

0xjojikun and others added 16 commits October 8, 2024 12:56
@0xjojikun
Add stripped down version of portal base
1814bcc
@jonathanprozzi
Removes unused .client and .server module files from template (first …
74903d9 
…pass)
@jonathanprozzi
Continues to remove several files to streamline template: schemas, as…
f4abbc4 
…sets/consts, action and resource routes, unused packages
@jonathanprozzi
Removes unused home route, removes extra consts and resources, update…
8cdd476 
…s app index
@jonathanprozzi
Adds the logout button -- removes changes to privy login for now (ste…
ef5ddb8 
…pping back to rework). Upgrades privy packages
@jonathanprozzi
Auth is now in a working state -- adds logging for troubleshooting
d4a4adc
@jonathanprozzi
Adds safeguards to remove any invalid chars from the verification key…
c9a385a 
… and includes if wanted
@jonathanprozzi
Updates provider configuration to support multiple login methods for …
6fc06f0 
…embedded wallets
@jonathanprozzi
Removes sentry and api, removes api instantiation from template, upda…
2917ff8 
…tes vite config
@jonathanprozzi
Strips back several compononents, hooks, and helpers that arent being…
ab16dc7 
… directly used in the template
@jonathanprozzi
Removes additional Portal specific items and fixes typecheck issues
f8c5761
@jonathanprozzi
Fixes padding issue on privy-login-button
36eb72b
@jonathanprozzi
Fixes pnpm-lock issue in ci/cd run
79bf13d
@jonathanprozzi
Fixes typecheck issues and lint issues caught in ci/cd -- need to add…
6330b13 
… this to nx commands
@jonathanprozzi
Drops version to 0.1.0 and adds typecheck so that it runs in pnpm typ…
0aedafc 
…echeck
@jonathanprozzi
Initial scaffolding for the data populator app within the monorepo
40317cb
@linear Linear
Copy link

linear bot commented Oct 11, 2024

ENG-4443 Apply Privy template to Data Populator in monorepo

@jonathanprozzi
Copy link
Member Author

jonathanprozzi commented Oct 17, 2024 •
edited
Loading

@0xjojikun I'll update the title checker to support the new packages outside of this PR, but thinking we should try to get this initial PR in so that we can branch from it instead of having a massive PR that we're all working on. What do you think?

@0xjojikun 0xjojikun changed the title ENG-4443 feat(data populator): scaffold data populator app ENG-4443 feat(data-populator): scaffold data populator app Oct 17, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-4443 feat(data-populator): scaffold data populator app ENG-4443 feat(data-populator,1ui): scaffold data populator app Oct 17, 2024
@jonathanprozzi jonathanprozzi enabled auto-merge (squash) October 17, 2024 20:31
@jonathanprozzi jonathanprozzi changed the title ENG-4443 feat(data-populator,1ui): scaffold data populator app ENG-4443 feat(1ui): scaffold data populator app Oct 17, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-4443 feat(1ui): scaffold data populator app ENG-4443 feat(data-populator,1ui): scaffold data populator app Oct 17, 2024
@0xjojikun 0xjojikun changed the title ENG-4443 feat(data-populator,1ui): scaffold data populator app ENG-4443 feat(data-populator, 1ui): scaffold data populator app Oct 17, 2024
@0xjojikun 0xjojikun changed the title ENG-4443 feat(data-populator, 1ui): scaffold data populator app ENG-4443 feat(data-populator,1ui): scaffold data populator app Oct 17, 2024
@0xjojikun 0xjojikun changed the title ENG-4443 feat(data-populator,1ui): scaffold data populator app ENG-4443 feat(repo): scaffold data populator app Oct 17, 2024
@0xjojikun 0xjojikun merged commit 03b5403 into main Oct 17, 2024
4 of 5 checks passed
@0xjojikun 0xjojikun deleted the eng-4443-scaffold-data-populator-app branch October 17, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjojikun 0xjojikun 0xjojikun approved these changes

Assignees
No one assigned
Labels
feat Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanprozzi @0xjojikun