Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4285 chore(portal): increase description length to 512 chars #857

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Increased max description length to 512 characters and fixed a couple other minor discrepancies.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Oct 7, 2024

ENG-4385 [Enhancement] Increase max description limit in the Portal

Looks like we set a relatively small max description limit recently; can we increase the number of characters allowed?

ENG-4285 Data Writes doc first iteration

https://www.notion.so/intuition-systems/Ponder-Data-Schema-10c450d37d068009b89bed9441970444?pvs=4

Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- do you recall if there was any actual reason for us setting this initial limit? I feel like BE supports any length, right?

@Vitalsine85
Copy link
Member Author

Nice -- do you recall if there was any actual reason for us setting this initial limit? I feel like BE supports any length, right?

Pretty sure it supports any length. Not sure if there was any actual reason as to why we set the initial limit. Makes me wonder if we just remove it or? Don't want to allow any crazy spam though.

@Vitalsine85 Vitalsine85 merged commit 8501c52 into main Oct 7, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/liv-168-enhancement-increase-max-description-limit-in-the-portal branch October 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants