ENG-4066 fix(portal): create claim combobox search fix #852
Conversation
ENG-4066 [Bug] Can’t create Claims on mobile due to formatting issues
When trying to select a Predicate or an Object, the search bar opens upwards like depicted in the screenshot attached, preventing you from searching for the Identity you want to compose your claim with. |
| return ( | ||
| <Popover | ||
| open={isObjectPopoverOpen} | ||
| onOpenChange={setIsObjectPopoverOpen} | ||
| modal={isObjectPopoverOpen} | ||
| modal={isMobileView ? false : isObjectPopoverOpen} |
There was a problem hiding this comment.
Oh interesting -- my understanding was that modal prop in Radix's Popover changed how it interacts with background objects
Is this also how they recommend solving the unexpected collision issues we had with the direction it opens?
There was a problem hiding this comment.
Yea, apparently when modal is set to true it disregards the placement and other properties. Can't really fully test this until it is on dev since I can't access localhost from my mobile device.
There was a problem hiding this comment.
If I remember correctly we had to set it to true so that scrolling worked on desktop. Everything still functions properly on desktop with this. I think that is going to be the main thing to test, scrolling on mobile with this change.
There was a problem hiding this comment.
Got it -- approved! Let's keep an eye on that in QA
…ile-due-to-formatting-issues
…ile-due-to-formatting-issues
Vitalsine85
deleted the
vital/eng-4066-bug-cant-create-claims-on-mobile-due-to-formatting-issues
branch
Affected Packages
Apps
Packages
Tools
Overview
This adds a check if the user is accessing the app from mobile and changes the modal prop on the Popover conditionally. Setting modal to true can cause some weird behavior on mobile. I was only able to test this locally in the dev console, so we will want to double check that it works once this is on staging.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration