Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4064 fix(portal): remove timeout from create identity #846

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Removes the timeout from the create identity form as it is no longer needed after updates were made to handle IPFS timeout on backend.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 17, 2024

ENG-4064 Bug: Race condition in create identity timeout checker likely causing error message after successful identity creation

TLDR:

Functional Requirement(s):

Task Breakdown - should translate to sub-issues if applicable:

  • [ ]

Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick fix!

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) September 17, 2024 20:16
@Vitalsine85 Vitalsine85 merged commit 21d6a6a into main Sep 17, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4064-bug-race-condition-in-create-identity-timeout-checker-likely branch September 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants