Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3699 fix(portal): user profiles user totals values #844

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Switches the call that we're using for getting the user's total values for staked identities in the profile overview to match what's being used in the Data Created view
  • Changes this on readonly and app

Screen Captures

User's profile:

user-totals-fix-profile

Another user's profile:

user-totals-fix-other-profile

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 16, 2024

ENG-3699 Wrong values returned from User Totals

On the profile dashboard (/app/profile), the 'User Stats' section is displaying incorrect values. All of these values are aggregates coming from userTotals; total_position_on_identities, total_positions_on_claims, total_position_value, total_identities, total_claims.

image.png

If you navigate to the 'Data Created' tab, you can see 'Active Positions'. These values come from totalEntries returned from pagination. As you can see, Identities is displaying a different value on this page than on the dashboard (62 vs 97). This value is more than likely the correct value. If not, then we have a bigger problem on our hands.

image.png

If you scroll down this page to the 'Created' section, these values again are coming from totalEntries. In this case, Identities seems to be accurate, as they're showing the same value as on the dashboard, but Claims is inaccurate (44 vs 54)

image.png

I also took a few to look into the TVL amounts and those seem to be accurate.

@0xjojikun
Copy link
Member

does this apply to any other endpoints or r we good?

@jonathanprozzi
Copy link
Member Author

does this apply to any other endpoints or r we good?

we're good, was just these

@jonathanprozzi jonathanprozzi merged commit 2797260 into main Sep 16, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-3699-fix-user-profiles-user-totals-values branch September 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants