Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4020 feat(portal): add dynamic metadata with satori #843

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Uses satori to generate dynamic open graph images
  • Refines approach to only leverage minimal query params for list, claim, and identity
  • Styling needs to use React Native / Satori specific approach
  • Note: We should check all the metadata properties for each of these, but I've been testing with ngrok and it's working in Discord shares. Not sure what Slack is looking for, but still want to tweak that.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 14, 2024

ENG-4020 Add dynamic metadata tags on detail pages

Reference i7n and possibly Satori

@github-actions github-actions bot added the feat Feature label Sep 14, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-4020 feat(portal): add dynamic metadata with satori (wip) ENG-4020 feat(portal): add dynamic metadata with satori Sep 15, 2024
@jonathanprozzi jonathanprozzi marked this pull request as ready for review September 15, 2024 17:31
@0xjojikun 0xjojikun merged commit d213c6d into main Sep 16, 2024
3 checks passed
@0xjojikun 0xjojikun deleted the eng-4020-add-dynamic-metadata branch September 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants