Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4013 feat(portal): create readonly route folder structure and add in read only views #839

Merged
merged 19 commits into from
Sep 12, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Adds in a /readonly+ route folder with routes for list, identity, claim, profile
  • Adjusts the auth to be used in /app routes
  • @0xjojikun and I then tag teamed the layouts and included a View in App CTA
  • Note: We still need to address CTA links within the components as these still go to the /app/ versions of the routes

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 12, 2024

ENG-4013 Create public/read only route structure outside of /app

We have our auth gating in our /app loader so anything nested inside the app directory inherits our auth gating. Since we want to remove auth gating for these public

Anything nested in our /app is therefore auth gated so for public views we'll need to create a directory outside of this

Thinking we can do something such as:

/read — I prefer /public but this may not be ideal since Remix has a public folder for a specific purpose

Steps:

  • Create this folder and add a loader that is a reverse auth gate:
    • If user isn't authenticated we set up the OpenAPI call header to use an API key — we'll also likely need to do this in some specific loaders (we can look at /app for example)
  • Create the routes that we need for public views nested within this folder

Update: Going to use /readonly

@github-actions github-actions bot added the feat Feature label Sep 12, 2024
@0xjojikun 0xjojikun enabled auto-merge (squash) September 12, 2024 22:19
@0xjojikun 0xjojikun merged commit ee45e87 into main Sep 12, 2024
3 checks passed
@0xjojikun 0xjojikun deleted the eng-4013-create-readonly-route-folder-structure branch September 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants