Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3866 fix(portal): allow users to remove profile image #824

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jonathanprozzi
Copy link
Member

@jonathanprozzi jonathanprozzi commented Sep 6, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Adds the ability for users to remove their profile picture
  • Passes in an explicitly empty string when the user is removing their profile picture (per the recent BE update that handles this) while also retaining the null check logic

Screen Captures

remove-user-profile-image-2

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
This pull request updates form data handling in EditProfileForm.tsx and removes an import statement for logger in ListClaimsList.tsx.

Key Points:

  • EditProfileForm checks previewImage before appending to form data.
  • ListClaimsList no longer uses logger.
  • Imports are added from '@components' and '@server/auth', and an import statement for 'logger' is removed.
  • The 'loader' function modifies a logging statement.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Sep 6, 2024

ENG-3866 Allow user to remove profile image

We discovered this in another Edit Profile related ticket (which we closed as the original issues were resolved)

Last week keegan changed how we're handling nulling the profile image, so we can resolve this issue.

Issue:

  • User not able to remove their profile image once uploaded

Original issue:

@github-actions github-actions bot added the fix Fix label Sep 6, 2024
@jonathanprozzi jonathanprozzi merged commit 6e53bff into main Sep 6, 2024
4 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-3866-user-remove-profile-image branch September 6, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants