Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-0000 fix(portal): revert fix nftPoints math #823

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Sep 5, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

This reverts commit ea49be4.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
This pull request replaces local NFT point calculation with the sum of mint and hold points. Changes are in Quests component of apps/portal/app/routes/app+/quest+/index.tsx.

Key Points:

  1. Removes local nftPoints calculation.
  2. Introduces nftMintPoints and nftHoldPoints.
  3. Updates totalNftPoints and relicsPoints props accordingly.
To turn off PR summary, please visit Notification settings.

@github-actions github-actions bot added the fix Fix label Sep 5, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) September 6, 2024 14:34
@Vitalsine85 Vitalsine85 merged commit 80b623e into main Sep 6, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-0000/revert-nft-math-update branch September 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants