Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3859 feat(portal): better navigation between list details list identity and tag claim #822

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Sep 4, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

This adds navigation elements to detail pages which link to any associated lists. This might change a bit after we make some modifications to lists, but in the meantime, this'll do.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary
This pull request introduces a new DetailInfoCard component and updates imports in various files. It replaces InfoCard with DetailInfoCard in some components and adds new properties and imports.

Key Points

  1. New DetailInfoCard component added in apps/portal/app/components/detail-info-card.tsx
  2. Replaces InfoCard with DetailInfoCard in ClaimDetails and imports new dependencies
  3. Updates IdentityLoaderData interface and useLiveLoader hook to load DetailInfoCard and new list property.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Sep 4, 2024

ENG-3859 Navigation between List Details, List Identity and Tag Claim

Description:

This is in reference to the ticket created by MK. PRO-27 This ticket is only to solve the navigation between the pages.

Attachments:

Problem Screenshots

Screenshot 2024-09-03 at 2.34.01 PM.png

Screenshot 2024-09-03 at 2.34.13 PM.png

Screenshot 2024-09-03 at 2.34.50 PM.png

Solution: Meta Data in Tag Claims and List Identity have a link to the List Details page.

Navigation between List Details, List Identity and Tag Claim - Features (Figma)


// Test Lead Notes //

@github-actions github-actions bot added the chore Chore label Sep 4, 2024
@@ -79,6 +85,21 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
throw new Response('Not Found', { status: 404 })
}

let list: ClaimPresenter | null = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to start moving away from using let we could try something like this --

const list = await ClaimsService.searchClaims({
  predicate: getSpecialPredicate(CURRENT_ENV).tagPredicate.id,
  object: identity.id,
})
  .then(listResult => listResult?.data[0] ?? null)
  .catch(error => {
    logger('Failed to fetch list:', error);
    return null;
  });

what do you think? i know we're mixing these patterns in our loaders so likely a bigger question but wondering what you think.

not blocking just a question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way works for me, I don't really have a preference. We should just have a quick chat and land on one or the other.

@jonathanprozzi
Copy link
Member

Looks good -- small question for us to consider
Also I think this should be a feat instead of a chore because it does add logic / reworks a component in 2 routes

@Vitalsine85 Vitalsine85 changed the title ENG-3859 chore(portal): better navigation between list details list identity and tag claim ENG-3859 feat(portal): better navigation between list details list identity and tag claim Sep 5, 2024
@Vitalsine85 Vitalsine85 added feat Feature and removed chore Chore labels Sep 5, 2024
@Vitalsine85 Vitalsine85 merged commit 4647685 into main Sep 5, 2024
7 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3859-navigation-between-list-details-list-identity-and-tag-claim branch September 5, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants