ENG-3857 fix(portal): use bigint in max math #819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Updates max calculation to do the math with BigInts and not decimals to further reduce the chance of rounding errors.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration
PR Summary by Typo
Summary
This pull request refactors
StakeActions
component instake-actions.tsx
, introducing a customformatDecimal
function and updatingmaxEth
calculation with BigInt andformatUnits
.Key Points
toLocaleString
withformatDecimal
.maxEth
using BigInt andformatUnits
.To turn off PR summary, please visit Notification settings.