Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3832 chore(portal): Lower the Sentry sample rate to 0.5 #815

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Aug 30, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

This PR lowers the Sentry sample rate to 0.5 to help prevent hitting our limits. It also removes the Chapter 3 Incident banner as that issue has been resolved.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
This pull request disables the production and staging banners and reduces Sentry's traces sample rate to 0.5 for both client-side and server-side.

Key Points:

  1. Disables banners in production and staging environments.
  2. Reduces Sentry's traces sample rate to 0.5 for client-side and server-side.
  3. Affects files in .github/workflows/deploy_production.yml, .github/workflows/deploy_staging.yml, apps/portal/app/entry.client.tsx, and apps/portal/instrumentation.server.mjs.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Aug 30, 2024

ENG-3832 [Sentry] Lower the sample rate

Lower the sample rate to reduce logs and prevent rate limiting

keegan: we can lower the sample rate more if needed on BE vital you may want to add a tech debt ticket to do the same. We should probably be fine with a sample rate of 0.5 or lower

@github-actions github-actions bot added the chore Chore label Aug 30, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) August 30, 2024 17:07
@Vitalsine85 Vitalsine85 merged commit 526b885 into main Aug 30, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-0000/remove-chapter-3-incident-banner branch August 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants