Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3748 fix(portal): fix timeout on create identity and claim flows #812

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Aug 29, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

This PR aims to improve error handling around create identity and create claim flows. It should provide more detailed toasts on API errors, as well as ensure that the transaction times out after 30 seconds, if the offchain POST does not complete in that time.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
This pull request reduces logout delay and introduces a new timeout mechanism for form submission in CreateIdentityForm.

Key Points:

  1. Logout delay reduced from 5s to 1.5s in privy-logout.tsx.
  2. New submitWithTimeout function added to create-identity-form.tsx for form submission with timeout and error handling.
  3. CreateIdentityForm changes: sets is_contract flag and refactors submitWithTimeout to return created identity.
  4. Error handling updated to provide more informative error messages.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Aug 29, 2024

ENG-3748 Fix the timeout on identity and claim creation

Problem: There should be a timeout on identity and claim creation that allows users to retry the action after 30 seconds. It is not triggering and users are stuck in loading, unable to go back/retry, and ultimately lose all of their data/have to fill the form out again.

Solution: Fix the timeout.

Attachments:

Screenshot 2024-08-23 at 3.04.04 PM.png

@Vitalsine85 Vitalsine85 changed the title more tinkering with timeouts ENG-3748 fix(portal): fix timeout on create identity and claim flows Aug 29, 2024
@github-actions github-actions bot added the fix Fix label Aug 30, 2024
@Vitalsine85 Vitalsine85 force-pushed the vital/eng-3748-fix-the-timeout-on-identity-and-claim-creation branch from 22e67aa to 2df3544 Compare September 4, 2024 18:49
@Vitalsine85 Vitalsine85 marked this pull request as ready for review September 4, 2024 18:51
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) September 4, 2024 18:51
@Vitalsine85 Vitalsine85 merged commit 2af07ea into main Sep 4, 2024
4 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3748-fix-the-timeout-on-identity-and-claim-creation branch September 4, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants