Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3737 fix(portal): add skip button to onboarding videos #800

Merged

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Aug 26, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Added a skip button to the relic onboarding videos. Also abstracted the video into a component that we can reuse throughout the flow.

Also did some testing for ENG-3744 and was unable to repro the issue. No changes were made related to this.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Aug 26, 2024

ENG-3737 [Intro Flow] Skip Button for Relic Animation

Description:

COMMUNITY FEEDBACK

Some users are getting hungup due to loading times for the relic animation (think third-world internet connection). We can add a skip button that force loads the next page. Solves two problems in 1 : )

@Vitalsine85 Vitalsine85 requested review from 0xjojikun and jonathanprozzi and removed request for 0xjojikun August 26, 2024 20:42
@Vitalsine85 Vitalsine85 marked this pull request as ready for review August 26, 2024 20:42
@Vitalsine85 Vitalsine85 changed the title ENG3737 fix(portal): add skip button to onboarding videos ENG-3737 fix(portal): add skip button to onboarding videos Aug 26, 2024
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 comment/question to make even more flexible. Glad we're adding in the skip though -- definitely will address some feedback with this!

const navigate = useNavigate()

const handleVideoEnd = () => {
navigate('/the-big-bang')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should make this a prop incase we change this destination route?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) August 27, 2024 14:35
@Vitalsine85 Vitalsine85 merged commit 9ea3af7 into main Aug 27, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3737-intro-flow-skip-button-for-relic-animation branch August 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants