Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ip argument to health check #1667

Merged
merged 3 commits into from
Dec 23, 2024
Merged

added ip argument to health check #1667

merged 3 commits into from
Dec 23, 2024

Conversation

cosmikwolf
Copy link
Contributor

added ip address argument to health check to address the bug I submitted earlier:

#1666

There may be issues with this pull request that I will resolve, the test suite did not seem to run properly on my M1 Mac, so I am hoping to see any issues that exist with your CI tools

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (fe84ab8) to head (7516b62).
Report is 167 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   93.88%   93.91%   +0.03%     
==========================================
  Files          78       80       +2     
  Lines        6361     6574     +213     
==========================================
+ Hits         5972     6174     +202     
- Misses        300      316      +16     
+ Partials       89       84       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@0xERR0R 0xERR0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Dec 23, 2024
@0xERR0R 0xERR0R added this to the v0.25 milestone Dec 23, 2024
@0xERR0R 0xERR0R merged commit f1386a0 into 0xERR0R:main Dec 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants