Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable "Special Use Domain Name" blocking #1614

Closed
wants to merge 3 commits into from

Conversation

mapl
Copy link
Contributor

@mapl mapl commented Sep 25, 2024

https://0xerr0r.github.io/blocky/latest/configuration/#special-use-domain-names

setting enable to false of specialUseDomains will unblock all Special Use Domain Names

specialUseDomains:
  enable: false

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (fe84ab8) to head (81cbd63).
Report is 141 commits behind head on main.

Files with missing lines Patch % Lines
resolver/sudn_resolver.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
+ Coverage   93.88%   94.12%   +0.23%     
==========================================
  Files          78       80       +2     
  Lines        6361     5052    -1309     
==========================================
- Hits         5972     4755    -1217     
+ Misses        300      213      -87     
+ Partials       89       84       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThinkChaos
Copy link
Collaborator

Thanks for making the change!

We'd also need to update the docs (docs/configuration.md and docs/config.yml).
And ideally add basic a test for IsEnabled (see Describe("IsEnabled", ...) in config/redis_test.go for an example).
If that's too much bother, let me know and I can do it.

Can you also explain a bit about your use case?

@mapl
Copy link
Contributor Author

mapl commented Sep 25, 2024

I would love to see you making the subsequent changes to the docs and test if you like
The use case is a dns migration where I successfully used blocky in the past to forward any dns query to the destination dns server. I really liked the exposed Prometheus metrics to track the remaining dns clients.

@mapl mapl closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants