-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics #1560
Update metrics #1560
Conversation
SuperQ
commented
Jul 28, 2024
- Use Prometheus naming best practices.
- Enable native histograms.
- Update dashboards to support new and old names.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
==========================================
+ Coverage 93.88% 93.96% +0.08%
==========================================
Files 78 79 +1
Lines 6361 5057 -1304
==========================================
- Hits 5972 4752 -1220
+ Misses 300 215 -85
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
* Use Prometheus [naming best practices](https://prometheus.io/docs/practices/naming/). * Enable native histograms. * Update dashboards to support new and old names. Signed-off-by: SuperQ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
thanks for your contribution! 🤝
@0xERR0R I was looking at the package layout for these metrics. I was going to open a PR to improve performance by moving the metrics to package local use. This would also eliminate the need for a bunch of inter-package channels and queuing. But, I'm not sure this architectural change would be accepted. |
@SuperQ I'm not sure if I fully understand what you mean, but you can always create a PR with a proposal and we can discuss you solution. If it makes things more performant and simpler -> that would be great |