Log the rule which is the cause of blocking

[zc-devs]

Part of #1458

Examples:

DEBUG Trie: wildcard block rule 'crashlytics.com' matched with 'firebase-settings.crashlytics.com'
DEBUG Trie: wildcard block rule 'telemetry.gfe.nvidia.com' matched with 'telemetry.gfe.nvidia.com'
DEBUG Trie: wildcard block rule 'mobile.events.data.microsoft.com' matched with 'mobile.events.data.microsoft.com'

DEBUG stringMap: block rule 'appboy.com' matched with 'appboy.com'
DEBUG stringMap: block rule 'app.adjust.com' matched with 'app.adjust.com'

[ThinkChaos]

Thanks for the PR!

I think ideally we should bubble up the info a bit further so the logs are associated with the request, and that we can even potentially return it through extended errors, or a blocky HTTP API, which would allow the blocky CLI to let you know what the rule is without needing to check logs.
To do that I'd probably update ListCache.Match to return a map[string]string which would use the group names as keys, and the rule that caused the block as value. From there, the compiler should show you what else needs to be updated up the stack, and down the stack you'd need to bridge Match and the code you've added in the caches.

That being said I think a debug like this is already a big UX improvement and can be merged if you don't want to take on extra work! No pressure either way!
In that case just fixing the lint errors is good, hopefully my suggestions do the trick :)

[zc-devs]

ideally we should bubble up the info a bit further ...

Agree. I just was afraid of changing trie.go too much.

To do that ...

Thanks for suggestions, I'll take it.

I think a debug like this is already a big UX improvement and can be merged if you don't want to take on extra work

Let's do not close the issue, but merge this PR as is. I will try to propagate the info in separate PR a little bit later.

[ThinkChaos]

Let's do not close the issue, but merge this PR as is. I will try to propagate the info in separate PR a little bit later.

Sure works for me!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.22%. Comparing base (fe84ab8) to head (8eff14f).
Report is 65 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
+ Coverage   93.88%   94.22%   +0.34%     
==========================================
  Files          78       78              
  Lines        6361     5007    -1354     
==========================================
- Hits         5972     4718    -1254     
+ Misses        300      198     -102     
- Partials       89       91       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.