Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support HumidifierAccessory #89

Merged
merged 2 commits into from
Nov 17, 2022
Merged

support HumidifierAccessory #89

merged 2 commits into from
Nov 17, 2022

Conversation

akaminsky-net
Copy link

Hey @0x5e,
I just bought Timberk Smart T-HU4-A100E-WF humidifier and noticed it's unsupported.
Here is small PR which adds support for humidifiers :)

@0x5e
Copy link
Owner

0x5e commented Nov 17, 2022

Thanks @akaminsky-net ! Let me have a look.

0x5e
0x5e requested changes Nov 17, 2022
View reviewed changes
Copy link
Owner

@0x5e 0x5e left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some space issues like configureTargetState(){ and const { HUMIDIFIER} = ... please have a check :)

Thanks for spending time doing this!

src/accessory/HumidifierAccessory.ts Outdated Show resolved Hide resolved
src/accessory/HumidifierAccessory.ts Outdated Show resolved Hide resolved
src/accessory/HumidifierAccessory.ts Outdated Show resolved Hide resolved
@0x5e 0x5e merged commit 1406e1c into 0x5e:develop Nov 17, 2022
@0x5e
Copy link
Owner

0x5e commented Nov 17, 2022

Thanks @akaminsky-net again ❤️

@0x5e 0x5e added this to the 1.6.0 milestone Nov 17, 2022
@0x5e
Copy link
Owner

0x5e commented Nov 24, 2022

Hi @akaminsky-net I made some modifications on HumidifierAccessory (#116 and #117), if anything goes wrong, please tell me, thanks :)

@akaminsky-net
Copy link
Author

Hi @akaminsky-net I made some modifications on HumidifierAccessory (#116 and #117), if anything goes wrong, please tell me, thanks :)

Sure, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5e 0x5e 0x5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akaminsky-net @0x5e