Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch command only if needed #229

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

hpstuff
Copy link

@hpstuff hpstuff commented Feb 1, 2023

I have Avatto smart thermostat. I saw in the log that when the mode is changed {switch: true} command is send every time this was preventing the mode to be set. I've tested it in the tuya device debug to send only the mode command and its work but if you add {switch: true} command (when the device is already on) along with the mode the mode is ignored

@0x5e
Copy link
Owner

0x5e commented Feb 6, 2023

Thanks for the contribution :)

We need a general solution for all devices:

  1. Skip send the command for those unchanged.
  2. Support send separate command.

Your commit is okay for this specific situation, thanks again.

@0x5e 0x5e merged commit 29afc9c into 0x5e:develop_1.7.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants