Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Camera support (sp). #137

Merged
merged 14 commits into from
Dec 14, 2022
Merged

Add initial Camera support (sp). #137

merged 14 commits into from
Dec 14, 2022

Conversation

0x5e
Copy link
Owner

@0x5e 0x5e commented Dec 7, 2022

Initial support with floodlight, motion detect, doorbell, and some switch buttons.

0x5e added 2 commits December 6, 2022 12:38
Reuse `OccupancyDetected`, `MotionDetected` Characteristics.
@0x5e 0x5e added this to the 1.7.0 milestone Dec 7, 2022
@ErrorErrorError
Copy link

Nice! I will be forking this soon and add support for cameras and doorbells!

@0x5e
Copy link
Owner Author

0x5e commented Dec 8, 2022

Thanks @ErrorErrorError !

The doorbell is included in this pr, but I'm not sure if we need the doorbell_pic. I guess if a camera doorbell contains doorbell_pic, it will always have doorbell_ring_exist? We can get the picture from doorbell_pic but maybe not useful... What do you think about it?

And we can split the pulsar and camera stream into the later PR, once the doorbell and motion event is done, I can publish a beta version for users to try.

@ErrorErrorError
Copy link

some doorbells use doorbell_pic or alert_message to notify when the doorbell was rang. We need it to notify when the data stored in the state changes.

@0x5e 0x5e mentioned this pull request Dec 10, 2022
@0x5e
Copy link
Owner Author

0x5e commented Dec 10, 2022

@ErrorErrorError Do you know the type and value of alert_message? This can't be found in the document.
And movement_detect_pic I tested is also a single event without motion event end notify, so if I use the MotionSensor, I need to set a default timeout to off the MotionDetected. What do you think about this?

@ErrorErrorError
Copy link

@ErrorErrorError Do you know the type and value of alert_message? This can't be found in the document.

And movement_detect_pic I tested is also a single event without motion event end notify, so if I use the MotionSensor, I need to set a default timeout to off the MotionDetected. What do you think about this?

Yeah most, if not all of the event notifications are single event, meaning they don't notify when there is no motion available. We will need to set a timeout that turns off MotionSensor.

In regards to alert_message, someone on scrypted under Tuya channel has that status info, which is how I found out about it.

ErrorErrorError and others added 2 commits December 14, 2022 11:49
#141)

* Added support for camera streaming and snapshot support (no HKSV support yet)

* Pass the lint issue

* Pass the lint issue

Co-authored-by: gaosen <[email protected]>
@0x5e 0x5e merged commit 7c9f2e5 into develop_1.7.0 Dec 14, 2022
@0x5e 0x5e deleted the feature/camera branch December 16, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants