Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logger, context; fix: download failure #16

Merged
merged 5 commits into from
Jul 5, 2024
Merged

feat: add logger, context; fix: download failure #16

merged 5 commits into from
Jul 5, 2024

Conversation

MiniFrenchBread
Copy link
Contributor

@MiniFrenchBread MiniFrenchBread commented Jul 4, 2024 •
edited
Loading

  • Add option for logger in core data structs
  • Add context as argument in async functions
  • Add download file check and failure handling

This change is Reviewable

@MiniFrenchBread MiniFrenchBread requested a review from boqiu July 4, 2024 12:12
@MiniFrenchBread MiniFrenchBread changed the title feat: logger, context feat: add logger, context; fix: download failure Jul 4, 2024
boqiu
boqiu approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MiniFrenchBread)

@MiniFrenchBread MiniFrenchBread merged commit 98b2184 into main Jul 5, 2024
2 checks passed
@MiniFrenchBread MiniFrenchBread deleted the options-improve branch July 5, 2024 08:58
@MiniFrenchBread MiniFrenchBread mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boqiu boqiu boqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiniFrenchBread @boqiu