Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shard #10

Merged
merged 2 commits into from
Jun 7, 2024
Merged

feat: shard #10

merged 2 commits into from
Jun 7, 2024

Conversation

MiniFrenchBread
Copy link
Contributor

@MiniFrenchBread MiniFrenchBread commented May 30, 2024 •
edited by sparkmiw
Loading

  • Remove disperse logic
  • Add shard, data segments will be assigned to storage nodes according to their shard configuration

This change is Reviewable

@MiniFrenchBread MiniFrenchBread requested a review from boqiu May 30, 2024 12:56
@MiniFrenchBread MiniFrenchBread marked this pull request as draft May 30, 2024 12:59
@MiniFrenchBread MiniFrenchBread marked this pull request as ready for review June 6, 2024 09:37
peilun-conflux
peilun-conflux approved these changes Jun 7, 2024
View reviewed changes
Copy link

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @boqiu)

@peilun-conflux peilun-conflux merged commit 98d74b7 into main Jun 7, 2024
2 checks passed
@peilun-conflux peilun-conflux deleted the shard branch June 7, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peilun-conflux peilun-conflux peilun-conflux approved these changes

@boqiu boqiu Awaiting requested review from boqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiniFrenchBread @peilun-conflux