Skip to content

Commit

Permalink
mm-move-madv_free-pages-into-lru_inactive_file-list-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: line over 80 characters
torvalds#127: FILE: mm/swap.c:571:
+		del_page_from_lru_list(page, lruvec, LRU_INACTIVE_ANON + active);

WARNING: please, no spaces at the start of a line
torvalds#177: FILE: mm/swap.c:654:
+ {$

total: 0 errors, 2 warnings, 133 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-move-madv_free-pages-into-lru_inactive_file-list.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Shaohua Li <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and sfrothwell committed Mar 7, 2017
1 parent 4caa18a commit d9d13bb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions mm/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,8 @@ static void lru_lazyfree_fn(struct page *page, struct lruvec *lruvec,
!PageUnevictable(page)) {
bool active = PageActive(page);

del_page_from_lru_list(page, lruvec, LRU_INACTIVE_ANON + active);
del_page_from_lru_list(page, lruvec,
LRU_INACTIVE_ANON + active);
ClearPageActive(page);
ClearPageReferenced(page);
/*
Expand Down Expand Up @@ -651,7 +652,7 @@ void deactivate_file_page(struct page *page)
* This is done to accelerate the reclaim of @page.
*/
void mark_page_lazyfree(struct page *page)
{
{
if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) &&
!PageUnevictable(page)) {
struct pagevec *pvec = &get_cpu_var(lru_lazyfree_pvecs);
Expand Down

0 comments on commit d9d13bb

Please sign in to comment.